chore(deps): Bump org.apache.fory:fory-core from 1.2.0 to 1.3.0#24262
chore(deps): Bump org.apache.fory:fory-core from 1.2.0 to 1.3.0#24262dependabot[bot] wants to merge 1 commit into
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
✅ POM dependency changes: targeted tests included Changed properties: fory-version Modules affected by dependency changes (1)
All tested modules (2 modules)
|
davsclaus
left a comment
There was a problem hiding this comment.
Fory 1.3.0 breaks on JDK 25 — the CI build (25, false) job fails with:
java.lang.IllegalStateException: JDK25+ string internals are inaccessible.
JDK25 zero-Unsafe mode requires java.base/java.lang.invoke to be open to Fory.
Use --add-opens=java.base/java.lang.invoke=ALL-UNNAMED
This is a regression: JDK 25 passes on main with fory 1.2.0. Fory 1.3.0 changed its internal string handling (PlatformStringUtils) to use java.lang.invoke APIs that JDK 25 no longer permits without explicit --add-opens.
Options:
- Wait for a fory release that handles JDK 25 without
--add-opens - Add
--add-openstocamel-fory's surefire argLine as a workaround (but this also means runtime users would need the same flag) - Close this PR and stay on fory 1.2.0 until upstream fixes JDK 25 support
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Claus Ibsen
|
upstream issue apache/fory#3788 |
|
I think we can go with providing the parameter in the maven surefire test, document that when using camel fory the parameter |
okay that is good |
|
@dependabot rebase |
Bumps org.apache.fory:fory-core from 1.2.0 to 1.3.0. --- updated-dependencies: - dependency-name: org.apache.fory:fory-core dependency-version: 1.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
65884db to
5f1f6d4
Compare
|
created a PR from a branch from my fork #24317 because I'm unable to push on Apache repo today |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
Fory 1.4.0 will add an Unsafe-based fallback path to get privileged invoke access, so I think it is reasonable to hold this upgrade for now and wait for the next Fory release. Longer term, though, it would still be good to support opening |
Bumps org.apache.fory:fory-core from 1.2.0 to 1.3.0.